Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move analysis_options.yaml into packages #460

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/dart.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Created with package:mono_repo v6.6.1
# Created with package:mono_repo v6.6.2
name: Dart CI
on:
push:
Expand Down Expand Up @@ -36,7 +36,7 @@ jobs:
name: Checkout repository
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
- name: mono_repo self validate
run: dart pub global activate mono_repo 6.6.1
run: dart pub global activate mono_repo 6.6.2
- name: mono_repo self validate
run: dart pub global run mono_repo generate --validate
job_002:
Expand Down
2 changes: 1 addition & 1 deletion pkgs/shelf/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@

## 0.6.1+2

* `logRequests` outputs a better message a request has a query string.
* `logRequests` outputs a better message if a request has a query string.

## 0.6.1+1

Expand Down
6 changes: 1 addition & 5 deletions analysis_options.yaml → pkgs/shelf/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
# https://dart.dev/guides/language/analysis-options

include: package:dart_flutter_team_lints/analysis_options.yaml

analyzer:
language:
strict-casts: true
strict-inference: true
strict-raw-types: true
errors:
comment_references: ignore # too many false positives

linter:
rules:
Expand All @@ -17,5 +14,4 @@ linter:
- missing_whitespace_between_adjacent_strings
- no_adjacent_strings_in_list
- no_runtimeType_toString
- package_api_docs
- unnecessary_await_in_return
2 changes: 2 additions & 0 deletions pkgs/shelf/lib/src/body.dart
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
import 'dart:async';
import 'dart:convert';

import 'message.dart';

/// The body of a request or response.
///
/// This tracks whether the body has been read. It's separate from [Message]
Expand Down
2 changes: 2 additions & 0 deletions pkgs/shelf/lib/src/hijack_exception.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

import 'request.dart';

/// An exception used to indicate that a request has been hijacked.
///
/// This shouldn't be captured by any code other than the Shelf adapter that
Expand Down
5 changes: 4 additions & 1 deletion pkgs/shelf/lib/src/message.dart
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ import 'package:http_parser/http_parser.dart';

import 'body.dart';
import 'headers.dart';
import 'middleware/logger.dart';
import 'request.dart';
import 'response.dart';
import 'shelf_unmodifiable_map.dart';
import 'util.dart';

Expand Down Expand Up @@ -171,7 +174,7 @@ abstract class Message {
{Map<String, String> headers, Map<String, Object> context, Object? body});
}

/// Adds information about [encoding] to [headers].
/// Adds information about encoding to [headers].
///
/// Returns a new map without modifying [headers].
Map<String, List<String>> _adjustHeaders(
Expand Down
1 change: 1 addition & 0 deletions pkgs/shelf/lib/src/middleware_extensions.dart
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import 'handler.dart';
import 'middleware.dart';
import 'pipeline.dart';

/// Extensions on [Middleware] to aid in composing [Middleware] and [Handler]s.
///
Expand Down
1 change: 1 addition & 0 deletions pkgs/shelf/lib/src/pipeline.dart
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

import 'handler.dart';
import 'middleware.dart';
import 'request.dart';

/// A helper that makes it easy to compose a set of [Middleware] and a
/// [Handler].
Expand Down
1 change: 1 addition & 0 deletions pkgs/shelf/lib/src/response.dart
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import 'dart:convert';

import 'package:http_parser/http_parser.dart';

import 'handler.dart';
import 'message.dart';
import 'util.dart';

Expand Down
4 changes: 2 additions & 2 deletions pkgs/shelf/lib/src/server.dart
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ import 'handler.dart';
/// code to a single server implementation.
///
/// There are two built-in implementations of this interface. You can create a
/// server backed by `dart:io` using [IOServer], or you can create a server
/// that's backed by a normal [Handler] using [ServerHandler].
/// server backed by `dart:io` using `IOServer`, or you can create a server
/// that's backed by a normal [Handler] using `ServerHandler`.
///
/// Implementations of this interface are responsible for ensuring that the
/// members work as documented.
Expand Down
1 change: 1 addition & 0 deletions pkgs/shelf_packages_handler/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
include: package:dart_flutter_team_lints/analysis_options.yaml
1 change: 1 addition & 0 deletions pkgs/shelf_proxy/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
include: package:dart_flutter_team_lints/analysis_options.yaml
1 change: 1 addition & 0 deletions pkgs/shelf_router/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
include: package:dart_flutter_team_lints/analysis_options.yaml
1 change: 1 addition & 0 deletions pkgs/shelf_router_generator/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
include: package:dart_flutter_team_lints/analysis_options.yaml
1 change: 1 addition & 0 deletions pkgs/shelf_static/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
include: package:dart_flutter_team_lints/analysis_options.yaml
1 change: 1 addition & 0 deletions pkgs/shelf_test_handler/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
include: package:dart_flutter_team_lints/analysis_options.yaml
2 changes: 2 additions & 0 deletions pkgs/shelf_test_handler/lib/src/expectation.dart
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

import 'package:shelf/shelf.dart';

import 'handler.dart';

/// A single expectation for an HTTP request sent to a [ShelfTestHandler].
class Expectation {
/// The expected request method, or `null` if this allows any requests.
Expand Down
1 change: 1 addition & 0 deletions pkgs/shelf_test_handler/lib/src/server.dart
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import 'dart:io';

import 'package:http_multi_server/http_multi_server.dart';
import 'package:shelf/shelf_io.dart';
import 'package:test/test.dart';

import 'handler.dart';

Expand Down
1 change: 1 addition & 0 deletions pkgs/shelf_web_socket/analysis_options.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
include: package:dart_flutter_team_lints/analysis_options.yaml
2 changes: 1 addition & 1 deletion tool/ci.sh
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/bash
# Created with package:mono_repo v6.6.1
# Created with package:mono_repo v6.6.2

# Support built in commands on windows out of the box.

Expand Down