Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move analysis_options.yaml into packages #460

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

devoncarew
Copy link
Member

  • move analysis_options.yaml into packages
  • regenerate mono_repo files

This catches a number of diagnostics in the shelf packages (mostly instances of comment_references diagnostics).


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@kevmoo
Copy link
Member

kevmoo commented Nov 22, 2024

But don't we like having fewer analysis_options files? Is this to work-around an analyzer bug?

@devoncarew
Copy link
Member Author

But don't we like having fewer analysis_options files?

Well, fewer analysis configurations for sure. Most of these are just include: package:dart_flutter_team_lints/analysis_options.yaml, which isn't really a maintenance issue.

Is this to work-around an analyzer bug?

I think there is a bug here, because I see different analysis results w/ one top level analysis file vs. the same configs, one in each package.

But I like having the packages be self-contained - not depend on files above them in the repo. And this also removes the persistent analysis diagnostic you see if you open the whole repo; the top-level analysis options file can't resolve its reference to package:dart_flutter_team_lints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants