Split before adjacent strings pushes string to the right

[MilanLi]

Before formatting:

it('should complete with an error if the name or website is null or both '
    'are unchanged', async(() {
  ICouldDoAnything();
}));

After formatting:

it(
    'should complete with an error if the name or website is null or both '        //<------ exceeds 80 chars limit
    'are unchanged', async(() {
  ICouldDoAnything();
}));

[maxwellpeterson-wf]

This is a common issue we see when writing unit tests with the test package as well.

[srawlins]

Since the formatter does not split string literals, there are many ways in which a string literal is "pushed to the right" such that it exists past 80 characters. Not much to do about that aside from splitting string literals.

But note, in the case summarized at the top, the new tall style formatting (in its WIP form) will break before the string literal, likely moving it left rather than right.

[munificent]

Right. The forthcoming tall style gives you:

it(
  'should complete with an error if the name or website is null or both '
  'are unchanged',
  async(() {
    ICouldDoAnything();
  }),
);

As @srawlins says, the formatter doesn't split strings so it may still push a long string past the end of the page, but in this case, it does so less and has the output I expect.