Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SchemeRegistrar : separate voting machine execution from scheme execution (register/unregister). #647

Open
orenyodfat opened this issue Jul 16, 2019 · 0 comments
Open

SchemeRegistrar : separate voting machine execution from scheme execution (register/unregister). #647

orenyodfat opened this issue Jul 16, 2019 · 0 comments

Comments

@orenyodfat
Copy link
Contributor

to enable voting machine execution even the scheme execution itself will revert.
see daostack/alchemy#918 for example.

might also consider to add permission check (>=2) on the proposal function .
@orenyodfat orenyodfat changed the title scheme registrar : separate voting machine execution from scheme execution (register/unregister). SchemeRegistrar : separate voting machine execution from scheme execution (register/unregister). Jul 16, 2019
@orenyodfat orenyodfat mentioned this issue Jul 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@orenyodfat