Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping sqlite like telescope-frecency? #48

Open
lkhphuc opened this issue Oct 12, 2023 · 1 comment
Open

Dropping sqlite like telescope-frecency? #48

lkhphuc opened this issue Oct 12, 2023 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@lkhphuc
Copy link

lkhphuc commented Oct 12, 2023

Hi,
Recently I saw that telescope-frecency has dropped the sqlite3 requirement, and since this plugin was inspired by that I wonder if it is considered to follow/borrow from it and drop this requirement as well.

I tried telescope-frecency and see it faster to startup as well, however I still like the "smart" search of this plugin.

Thanks for the plugin.

@danielfalk
Copy link
Owner

It doesn't have any requirements that are so complex that they would absolutely require it, but sqlite is supposed to be good at querying and sorting, which it does quite well. I hadn't actually noticed a perceptible delay in opening - at least not one that I could attribute to the persistence mechanism. And unfortunately, while I'm grateful to telescope-frecency project for inspiration and the initial codebase, this project has evolved so much since then that it wouldn't be trivially easy to pull in that implementation I would imagine.

Even so, having fewer dependencies makes for an easier installation, and if it's true that opening the picker is noticeably faster, that would be good too. I'd be willing to take a PR for it if anyone's willing to contribute a noticeable performance improvement on that initial popup. I probably wouldn't be able to contribute this work due to other priorities, but I do respond quickly to PRs

Thanks for the input.

@danielfalk danielfalk added the help wanted Extra attention is needed label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants