Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hypothesis grids crash when empty samples occur #46

Open
matiscke opened this issue Mar 15, 2024 · 2 comments · May be fixed by #54
Open

Hypothesis grids crash when empty samples occur #46

matiscke opened this issue Mar 15, 2024 · 2 comments · May be fixed by #54
Labels
bug Something isn't working

Comments

@matiscke
Copy link
Collaborator

In the case where a grid of parameters in a test_hypothesis_grid leads to an empty sample, the run gets stuck*.

*progress bar doesn't progress anymore, task keeps running until interrupted.
@matiscke matiscke added the bug Something isn't working label Mar 15, 2024
@astral-carrier
Copy link
Contributor

I had my progress bar hang for nearly 20 minutes, but then it unfroze and immediately jumped to 100%.

It took about 39 minutes in total to run code cell 11 on Example1.ipynb, which is in line with my previous runs.

I suspect the issue is the progress bar being inaccurate, as opposed to a bug with test_hypothesis_grid. How long did you wait on your task before interrupting it?

@matiscke
Copy link
Collaborator Author

I did try smaller grids that should finish within minutes. With certain choices of parameter range it got stuck, with others it finished. I could not fully verify that only the empty-sample-cases get stuck, but my test runs were consistent with that.

@astral-carrier astral-carrier mentioned this issue Mar 21, 2024
Closed
@astral-carrier astral-carrier linked a pull request May 16, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@matiscke @astral-carrier