Add partial role support for manager only #5219
Conversation
|
This PR needs a web-vault built from this PR dani-garcia/bw_web_builds#186 But it would be nice if some people are able to test this PR using a web-vault built from the PR linked above. |
BlackDex
force-pushed
the
mngr-custom-role
branch
from
78ab1c1
to
4b283b2
Compare
May I suggest to add more comments to the code, where your changes from this PR have to be reverted when full role support is implemented. Unless you you'll keep the compat layer even then. It is quite possible to forget to remove/change current code/behavior when the "future" changes are not close to this PR. Please ignore, if I am way off. |
BlackDex
force-pushed
the
mngr-custom-role
branch
2 times, most recently
from
ae62f5b
to
6e337c6
Compare
|
@tessus done :) @stefan0xC I have fixed the icon in the collapsed menu. |
BlackDex
force-pushed
the
mngr-custom-role
branch
2 times, most recently
from
de0b54c
to
0a4ffc7
Compare
|
As mentioned before, this PR needs a new web-vault version for which a PR can be found here: CI builds of this web-vault can be downloaded here:
|
- Add the custom role which replaces the manager role - Added mini-details endpoint used by v2024.11.1 These changes try to add the custom role in such a way that it stays compatible with the older manager role. It will convert a manager role into a custom role, and if a manager has `access-all` rights, it will enable the correct custom roles. Upon saving it will convert these back to the old format. What this does is making sure you are able to revert back to an older version of Vaultwarden without issues. This way we can support newer web-vault's and still be compatible with a previous Vaultwarden version if needed. In the future this needs to be changed to full role support though. Signed-off-by: BlackDex <[email protected]>
Signed-off-by: BlackDex <[email protected]>
Signed-off-by: BlackDex <[email protected]>
BlackDex
force-pushed
the
mngr-custom-role
branch
from
71d90ed
to
31957cc
Compare
These changes try to add the custom role in such a way that it stays compatible with the older manager role. It will convert a manager role into a custom role, and if a manager has
access-allrights, it will enable the correct custom roles. Upon saving it will convert these back to the old format.What this does is making sure you are able to revert back to an older version of Vaultwarden without issues. This way we can support newer web-vault's and still be compatible with a previous Vaultwarden version if needed.
In the future this needs to be changed to full role support though.