Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Removing lua bindings #41

Open
RuhiRG opened this issue Aug 23, 2023 · 0 comments
Open

RFC: Removing lua bindings #41

RuhiRG opened this issue Aug 23, 2023 · 0 comments

Comments

@RuhiRG
Copy link
Member

RuhiRG commented Aug 23, 2023

Since the refactors for #35, the lua bindings to functions have stopped working. This is expected, the lua bindings relied on objects being constructed in C++ and provided to the lua environment. With pyseams however, this is no longer required.

As currently written, the functions.lua files are used to call C++ functions, but they can be removed, the CLI should be used with the lua variables and yaml files to run the analysis in functions.lua.

For backwards compatibility I would propose adding these C++ only workflows to the CLI while removing the lua bindings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant