You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since the refactors for #35, the lua bindings to functions have stopped working. This is expected, the lua bindings relied on objects being constructed in C++ and provided to the lua environment. With pyseams however, this is no longer required.
As currently written, the functions.lua files are used to call C++ functions, but they can be removed, the CLI should be used with the lua variables and yaml files to run the analysis in functions.lua.
For backwards compatibility I would propose adding these C++ only workflows to the CLI while removing the lua bindings.
The text was updated successfully, but these errors were encountered:
Since the refactors for #35, the
lua
bindings to functions have stopped working. This is expected, thelua
bindings relied on objects being constructed in C++ and provided to thelua
environment. Withpyseams
however, this is no longer required.As currently written, the
functions.lua
files are used to call C++ functions, but they can be removed, the CLI should be used with thelua
variables andyaml
files to run the analysis infunctions.lua
.For backwards compatibility I would propose adding these C++ only workflows to the CLI while removing the
lua
bindings.The text was updated successfully, but these errors were encountered: