Skip to content
This repository has been archived by the owner on Nov 22, 2018. It is now read-only.

Concurrent map read and map write when multiple reads #150

Open
cznic opened this issue Jan 29, 2017 · 4 comments
Open

Concurrent map read and map write when multiple reads #150

cznic opened this issue Jan 29, 2017 · 4 comments
Assignees
Labels

Comments

@cznic
Copy link
Owner

cznic commented Jan 29, 2017

Cf.: fluxcd/flux#393.

@cznic cznic added the bug label Jan 29, 2017
@cznic cznic self-assigned this Jan 29, 2017
@gernest gernest mentioned this issue May 5, 2017
@gernest
Copy link
Collaborator

gernest commented May 8, 2017

I wonder if there is away to reproduce this. It looks nasty.

@cznic
Copy link
Owner Author

cznic commented May 8, 2017

Unfortunately, we have no answer from @philwinder yet.

@twitchyliquid64
Copy link
Collaborator

I encountered this with multiple writes and a single read. Was unable to reproduce again, despite doing the same thing for the next two weeks. There were over 200 go-routines running at the time of the crash.

If we can't repro, can we put in some recover() at the top of ql somewhere, and collect information (that can be dumped to the console, before rebubbling the panic) that will help debug in the future?

@cznic
Copy link
Owner Author

cznic commented Jul 12, 2017

If we can't repro, can we put in some recover() at the top of ql somewhere, and collect information (that can be dumped to the console, before rebubbling the panic) that will help debug in the future?

Provided the error is recoverable, which I don't know, I like the idea. I'm sending you a collaborator's invitation in case you would like to create the patch. If so, please make it a separate branch for easy reviewing before merging it eventually, thank you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants