Build configuration no longer defines HAVE_FUNC

[zsoi]

I'm running a gentoo system with cyrus-sasl-2.1.26-r2 installed and I observed that I no longer get function names printed in logs:

May 31 11:26:09 hostname saslauthd[19626]:                 : master exited: 19626
May 31 11:26:09 hostname saslauthd[438]:                 : master pid is: 438
May 31 11:26:09 hostname saslauthd[438]:                 : listening on socket: /run/saslauthd/mux

(see the empty space where usually the function name is located)

I did some research, the gentoo portage tree usually had a patch that would fix up this issue for 2.1.25 in configure.h.in (https://gitweb.gentoo.org/repo/gentoo.git/tree/dev-libs/cyrus-sasl/files/cyrus-sasl-2.1.25-autotools_fixes.patch) but since the move to configure.ac the patch doesn't apply anymore and it also wasn't renewed for configure.ac.

The issue is that the configure script never defines HAVE_FUNC which makes the code

cyrus-sasl/saslauthd/utils.h

Lines 61 to 73 in 284be6f

	#ifdef HAVE_FUNC
	# define L_FUNC __func__
	# define HAVE_L_FUNC 1
	#elif defined(HAVE_PRETTY_FUNCTION)
	# define L_FUNC __PRETTY_FUNCTION__
	# define HAVE_L_FUNC 1
	#elif defined(HAVE_FUNCTION)
	# define L_FUNC __FUNCTION__
	# define HAVE_L_FUNC 1
	#else
	# define L_FUNC ""
	# undef HAVE_L_FUNC
	#endif

believe that it can't use __func__ for passing to the logging method. auth_rimap logging e.g. still works because it directly calls syslog with the __func__ constant.

Unfortunately I lack the experience to quickly put up a patch and test it, but maybe this is a straightforward issue to fix for an experienced developer. Also maybe I have to file this issue with the portage maintainer, because it's specific to the gentoo distribution, after all, they already had to patch this for an older cyrus-sasl version.