Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Cannot find module 'node-zlib-backport' from '.../node_modules/pngjs/lib' #3653

Closed
janusqa opened this issue Mar 6, 2019 · 2 comments

Comments

@janusqa
Copy link

janusqa commented Mar 6, 2019

Current behavior:

Running test with a blink-diff import causes error

Error: Cannot find module 'node-zlib-backport' from '.../cypress-test-tiny-plugin-esm/node_modules/pngjs/lib'

Desired behavior:

Steps to reproduce: (app code and test code)

https://github.com/janusqa/cypress-test-tiny-plugin2-esm

Run test to see error.

Versions

chrome: Version 72.0.3626.121 (Official Build) (64-bit)
linux: Ubuntu 18.04.2 LTS
Cypress package version: 3.1.5
Cypress binary version: 3.1.5

@nym
Copy link

nym commented May 8, 2019

Also having this issue.

@jennifer-shehane
Copy link
Member

I was able to reproduce the error with the repo provided with Cypress version 3.3.0.

This looks to be a problem from pngjs with browserify which has been fixed https://github.com/lukeapage/pngjs/issues?q=is%3Aissue+sort%3Aupdated-desc+node-zlib-backport+is%3Aclosed a long time ago toriningen/pngjs@9181129

pngjs is a dependency of blink-diff

[email protected] /Users/jennifer/Dev/cypress-test-tiny-plugin2-esm
└─┬ [email protected]
  └─┬ [email protected]
    └── [email protected]

There's a current issue to upgrade pngjs in blink-diff you may want to comment on: yahoo/blink-diff#32 But it looks like their still using the pngjs version from 2016, so not sure.

Someone also mentioned:

I believe you can tell browserify to ignore modules (null them out). Thats what another project using browserify with this package is doing.

@jennifer-shehane jennifer-shehane added the stage: awaiting external fix A 3rd party bug in Cypress - awaiting release label May 22, 2019
@jennifer-shehane jennifer-shehane removed the stage: awaiting external fix A 3rd party bug in Cypress - awaiting release label Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants