Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in compare nodes #24

Open
gidden opened this issue Jun 7, 2013 · 0 comments
Open

bug in compare nodes #24

gidden opened this issue Jun 7, 2013 · 0 comments
Assignees

Comments

@gidden
Copy link
Member

gidden commented Jun 7, 2013

there appears to be a large bug in the compare nodes function. I can't isolate it with small test cases as of yet, but it came about as I was comparing inpro files. for some reason my expected inpro file had the recipes missing, but compare_nodes still returned true. I was actually able to gut the entire file except for the region node and have it still return true.

I've provided some tests in my branch test-compare-hotfix that currently fail but should pass. This will most likely require pretty extensive additional unit tests for different tree structure cases and a revisit of the comparison algorithm.

@ghost ghost assigned gidden Jun 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant