This repository has been archived by the owner on Mar 27, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1223, skips running all code in environments without
window
object. This is done to avoidReferenceError: window is not defined
error that happens in Node.js when importingiscroll
module. Scroller functionality is not required during server-side render, but usually will be triggered on the client-side wherewindow
object is available.Tested on our project with vue-iscroll-view, which is a wrapper Vue component for
iscroll
. SSR works ignoring scroller functionality and client-side works by applying scroller inmounted
hook (only called on client-side), this is done by iscroll-view component.