Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test all assertion methods #1

Open
csparpa opened this issue Feb 10, 2019 · 7 comments
Open

Unit test all assertion methods #1

csparpa opened this issue Feb 10, 2019 · 7 comments

Comments

@csparpa
Copy link
Owner

csparpa commented Feb 10, 2019

Ideally, test coverage of assertion methods (eg. is_none(), is_not_none(), etc.) should be 100%

@deanagan
Copy link
Collaborator

Hi @csparpa , I've submitted a pull request for the dicts testing. I will try to get some done on the other ones.

@hedyhli
Copy link
Contributor

hedyhli commented Jun 30, 2020

Hello, is this issue still available?

I went over the files and found that for Check there is sequences tests missing

@deanagan
Copy link
Collaborator

The unit tests are not complete. From the last time I ran it, the code coverage isn't 100%.

@deanagan
Copy link
Collaborator

I ran it just now. We are at 94% code coverage.

@hedyhli
Copy link
Contributor

hedyhli commented Jun 30, 2020

Yeah same for me, I started working on test_sequences for Check in my fork haven't finished yet. I'm not sure if the format is good either, you can check it out if you like. Although the python setup.py test is running ok, I haven’t checked the coverage report after adding test_sequences just yet

@csparpa
Copy link
Owner Author

csparpa commented Jun 30, 2020

@hedythedev thanks for contributing to fluentcheck! If you're testing the Check assertions, also pls take the chanche also to write the same tests - if missing - for the Is idiom.

@hedyhli
Copy link
Contributor

hedyhli commented Jun 30, 2020

Got it, I checked a few hours ago that there were tests for sequences for Is, but tests for sequences for Check is missing so i was working on it as I said in the comment above :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants