Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reason for only Begin/EndBlock panic checks #6

Open
JasperSurmont opened this issue Apr 20, 2023 · 4 comments
Open

Reason for only Begin/EndBlock panic checks #6

JasperSurmont opened this issue Apr 20, 2023 · 4 comments
Assignees

Comments

@JasperSurmont
Copy link

The beginendblock rule checks for panics in these ABCI calls. Is there a reason that this check is only performed in these 2 situations? For example, why not in the CheckTx ABCI call?

Thanks!

@yihuang
Copy link

yihuang commented Apr 21, 2023

Because begin/end block panic will halt the node?

@JasperSurmont
Copy link
Author

Because begin/end block panic will halt the node?

I understand, but why wouldn't e.g. panics in DeliverTx halt?

@yihuang
Copy link

yihuang commented Apr 21, 2023

Because begin/end block panic will halt the node?

I understand, but why wouldn't e.g. panics in DeliverTx halt?

There's a panic recovery in sdk's runTx function

@JasperSurmont
Copy link
Author

Ah thanks!
Is there any reason why there is none in Begin/EndBlock?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants