Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix background.type manifest property typescript type #916

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix background.type manifest property typescript type #916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
144d35c
Update manifest.ts
hichemfantar Sep 9, 2024
d62003b
Update manifest.ts
hichemfantar Sep 9, 2024
c9a6c42
Add changeset
jacksteamdev Oct 27, 2024
1b296a2
Merge branch 'main' into main
jacksteamdev Oct 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tiny-moose-occur.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@crxjs/vite-plugin": patch
---

fix background.type manifest property typescript type
2 changes: 1 addition & 1 deletion packages/vite-plugin/src/node/manifest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export interface WebAccessibleResourceById {

export interface ChromeManifestBackground {
service_worker: string
type?: 'module' // If the service worker uses ES modules
type?: 'module' | (string & {}) // If the service worker uses ES modules
}

export interface FirefoxManifestBackground {
Expand Down
Loading