Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make variable to specify the Terraform Provider Artifact Repo & Document specifying other download locations #16

Open
luebken opened this issue Nov 7, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@luebken
Copy link

luebken commented Nov 7, 2022

What problem are you facing?

The Terraform provider I've been working on pushes it's binaries to GitHub.

@turkenh was so kind to point me to the right Dockerfile line: https://github.com/luebken/provider-aiven/pull/1/files

How could Upbound help solve your problem?

Document ${TERRAFORM_PROVIDER_DOWNLOAD_NAME} and an how to specify other downloads locations.

@luebken luebken added enhancement New feature or request needs-epic-link labels Nov 7, 2022
@luebken luebken changed the title The Terraform provider I've been working on pushes it's binaries to GitHub. Document other download locations Nov 7, 2022
@luebken luebken added documentation and removed enhancement New feature or request needs-epic-link labels Dec 13, 2022
@ulucinar
Copy link
Collaborator

ulucinar commented Dec 20, 2022

We had also better revisit the hardcoded repo root here and expose it as a Make variable so that it will be easier for folks to utilize other download locations (possibly without a need to change the Dockerfile manually), and we can then document this. cc. @ytsarev regarding our discussion on slack and your observations.

@ulucinar ulucinar added the enhancement New feature or request label Dec 20, 2022
@ulucinar
Copy link
Collaborator

Added the enhancement label to reflect the Dockerfile & Makefile changes.

@ulucinar ulucinar changed the title Document other download locations Make variable to specify the Terraform Provider Artifact Repo & Document specifying other download locations Dec 20, 2022
@ulucinar
Copy link
Collaborator

ulucinar commented Dec 20, 2022

There's even a Terraform registry API which we can utilize to determine the download URL, which will simplify this task. In fact, it can just be enough to specify the native provider name & version (like it's sufficient for the Terraform CLI in the Terraform required_providers configuration block, i.e. with the source and version arguments, where source is not a URL but a provider name like hashicorp/aws). This would remove the burden of finding out the actual download location (URL) as long as the provider is registered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants