-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize Crossplane conformance suite #31
base: main
Are you sure you want to change the base?
Conversation
…onformance testing Signed-off-by: Jared Watts <[email protected]>
Signed-off-by: Jared Watts <[email protected]>
oh wow, off to a pretty poor start for the CI in https://github.com/crossplane/conformance/actions/runs/11259504031/job/31308621246?pr=31 🙄
|
Signed-off-by: Jared Watts <[email protected]>
Signed-off-by: Jared Watts <[email protected]>
Signed-off-by: Jared Watts <[email protected]>
Signed-off-by: Jared Watts <[email protected]>
- this is to avoid the conflict with xpkg-action's and crossplane's install.sh download of the crank binary to a file called crossplane Signed-off-by: Jared Watts <[email protected]>
Signed-off-by: Jared Watts <[email protected]>
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Signed-off-by: Jared Watts <[email protected]>
- install a function and verify it becomes installed and healthy - create a composition that uses pipeline mode to compose resources with functions Signed-off-by: Jared Watts <[email protected]>
@negz I've moved this PR out of draft after getting it to state I'm feeling decent about. I'll continue some more clean up work, but the bulk of what I wanted to accomplish here is now completed. Let me know if you'd like a sync session to walk through these changes effectively together, or how I can help make your review easier. Thank you! 🙇 |
Signed-off-by: Jared Watts <[email protected]>
Signed-off-by: Jared Watts <[email protected]>
Description of your changes
This PR updates the Crossplane conformance test suite and build logic to be aligned and compliant with Crossplane v1.17. The tests are all now compliant with a Crossplane v1.17 control plane. The current builds in this repo were last verified to work with Crossplane v1.2, so there were a number of updates to incorporate from those 15 intermediary minor releases.
This will stay in draft status for the remaining work items:
Major changes to call out:
crossplane-runtime:v1.17.0
1.23.2
,ubuntu-24.04
runners, etc.codeql
andtrivy-scan-fs
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
I have run all tests locally against a v1.17 Crossplane control plane with the following command:
Everything passes with the exception of
TestConfiguration
, which will not pass until we updateindex.docker.io/crossplane/conformance-testdata-configuration:latest
after merging the CI changes included in the PR. I have gotten that test case to pass locally though by temporarily usingxpkg.upbound.io/jaredorg/conformance-testdata-configuration:v0.0.1
, which is essentially the same thing.