Unable to run refresh on LinuxVirtualMachineScaleSet

[nstott]

What happened?

After building a LinuxVirtualMachineScaleSet resource, I get the error condition:

  - lastTransitionTime: "2023-08-08T22:05:31Z"
    message: 'observe failed: cannot run refresh: refresh failed: Missing required
      argument: The argument "enabled" is required, but no definition was found.'
    reason: ReconcileError
    status: "False"
    type: Synced

How can we reproduce it?

Building the example in https://marketplace.upbound.io/providers/upbound/provider-azure-compute/v0.35.0/resources/compute.azure.upbound.io/LinuxVirtualMachineScaleSet/v1beta1#doc:spec-forProvider-networkInterface-ipConfiguration-publicIpAddress-publicIpPrefixId will reproduce the error

What environment did it happen in?

• Crossplane Version: 'stable', not sure
• Provider Version: 0.35
• Kubernetes Version:

Client Version: version.Info{Major:"1", Minor:"27", GitVersion:"v1.27.4", GitCommit:"fa3d7990104d7c1f16943a67f11b154b71f6a132", GitTreeState:"clean", BuildDate:"2023-07-19T12:20:54Z", GoVersion:"go1.20.6", Compiler:"gc", Platform:"darwin/amd64"}
Kustomize Version: v5.0.1
Server Version: version.Info{Major:"1", Minor:"26", GitVersion:"v1.26.6", GitCommit:"11902a838028edef305dfe2f96be929bc4d114d8", GitTreeState:"clean", BuildDate:"2023-06-19T16:11:29Z", GoVersion:"go1.19.10", Compiler:"gc", Platform:"linux/amd64"}

• Kubernetes Distribution: AKS

[prfj]

Same issue is happening with WindowsVirtualMachineScaleSet

[prfj]

I migrated from 0.34 to 0.36 without provider family and started to have a lot of issues like the one describe in this issue, for resources where the CRD changed.

After install >0.34, the provider put a new controller running, but didn't updated/took ownership of the existing CRDs

0.35 - https://github.com/upbound/provider-azure/blob/e0bb020ca71ebc9b7ad0f2c35de9fed29c796fa0/package/crds/compute.azure.upbound.io_windowsvirtualmachinescalesets.yaml#L141C19-L141C42 - "enable" field inside "automaticInstanceRepair" on 0.35 is not required.

0.34 - https://github.com/upbound/provider-azure/blob/8838beed1432b26d7dffd236007b426942ee926d/package/crds/compute.azure.upbound.io_windowsvirtualmachinescalesets.yaml#L143 - "enable" field inside "automaticInstanceRepair" on 0.34 is required.

After this i tested with provider families and i was not able to replicate the issue, i created resources with 0.34 and after change provider to 0.36 the CRD was updated by new providerrevision...

[nstott]

Thanks, I'll check that out.
my issue happened with a fresh install, and no previous crd's. I'll add the automaticInstanceRepair field and see if that changes

[turkenf]

Hi @nstott,

We have a new provider version that fixes this kind of bug(related PR), could you please try it with v0.36.0 and let us know?

[nstott]

that seems to have fixed the issue for me, thank you