Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Cluster is missing Network and Subnetwork references #75

Open
micnncim opened this issue Sep 25, 2022 · 0 comments · May be fixed by #76
Open

Cluster is missing Network and Subnetwork references #75

micnncim opened this issue Sep 25, 2022 · 0 comments · May be fixed by #76
Labels
enhancement New feature or request

Comments

@micnncim
Copy link

micnncim commented Sep 25, 2022

What problem are you facing?

Currently, the Cluster managed resource is missing reference fields to Network and Subnetwork resources1.

It'd be unexpected to users because the Cluster resource in provider-gcp has references to both2 and other resources in this provider like the Subnetwork resource3.

While it's possible to specify Network and Subnetwork resources with the network and subnetwork fields, the value of the fields must be selfLink. This would make it annoying to configure them and it harder to create compositions.

How could GCP Provider help solve your problem?

References should be added.

Footnotes

  1. https://github.com/crossplane-contrib/provider-jet-gcp/blob/40c122feea/apis/container/v1alpha2/zz_cluster_types.go#L178-L363

  2. https://github.com/crossplane-contrib/provider-gcp/blob/v0.21.0/apis/container/v1beta2/cluster_types.go#L245-L253

  3. https://github.com/crossplane-contrib/provider-jet-gcp/blob/40c122feea/apis/compute/v1alpha2/zz_subnetwork_types.go#L127-L131

@micnncim micnncim added the enhancement New feature or request label Sep 25, 2022
@micnncim micnncim linked a pull request Sep 25, 2022 that will close this issue
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant