Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Font Awesome 5 incompatible because of prefix change from "fa" to "fas"/"fab" #184

Open
kmindi opened this issue Jun 11, 2020 · 0 comments

Comments

@kmindi
Copy link

kmindi commented Jun 11, 2020

Version

2.0.6

Reproduction link

https://example.com/sorryIhavenotputalldemofilesonjsfiddleorsimilar

Operating System

Any

Device

Any

Browser & Version

Any

Steps to reproduce

Use current Font Awesome 5 instead of deprecated 4.7 (which is the latest that is delivered by the maxcdn link currently used)

What is expected?

I would expect this great theme to follow dependency updates such as Font Awesome

What is actually happening?

No icons shown for used FA Icons in menu


Solution

https://fontawesome.com/how-to-use/on-the-web/setup/upgrading-from-version-4

E.g. use new link:

<link rel="stylesheet" href="https://use.fontawesome.com/releases/v5.13.0/css/all.css">
  <link rel="stylesheet" href="https://use.fontawesome.com/releases/v5.13.0/css/v4-shims.css">

better not use that v4-shim and change usages of "fa" to either "fas" or "fab" (for brand icons).

Also I guess the fonts should be stored locally/along the theme/website and no more gotten from their CDN.

Additional comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant