when getting variants for NestedElementsController, include disabled too #3772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the
nested-elements/reorderaction is called for product variants, thebeforeAction()method callsgetVariants()via magic getter and a collection of elements is returned. By default,getVariants()doesn’t grab disabled elements.For reordering to work in that case, the disabled elements have to be returned, too.
(I opted to amend the getter for the other NestedElementsController action, too (delete). Commerce doesn’t seem to use it at the moment, but just in case.)
Related issues
#3769