Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze PL_sv_zero properly #91

Open
toddr opened this issue Apr 8, 2022 · 5 comments
Open

Freeze PL_sv_zero properly #91

toddr opened this issue Apr 8, 2022 · 5 comments

Comments

@toddr
Copy link
Member

toddr commented Apr 8, 2022

No description provided.

@atoomic
Copy link
Collaborator

atoomic commented Apr 8, 2022

note: PL_Zero is the PV of PL_sv_zero
We probably want to freeze PL_sv_zero in this case

@atoomic atoomic changed the title Freeze PL_zero properly Freeze PL_sv_zero properly Apr 8, 2022
@atoomic
Copy link
Collaborator

atoomic commented Apr 8, 2022

need to check for other special SVs*

@atoomic
Copy link
Collaborator

atoomic commented Apr 8, 2022

B::SPECIAL should already take care of these PL_*

@atoomic
Copy link
Collaborator

atoomic commented Apr 8, 2022

from B

 our @specialsv_name = qw(Nullsv &PL_sv_undef &PL_sv_yes &PL_sv_no
             (SV*)pWARN_ALL (SV*)pWARN_NONE (SV*)pWARN_STD
                         &PL_sv_zero);

@atoomic
Copy link
Collaborator

atoomic commented Apr 11, 2022

idea: check for common PVs strings when generating a COWPV
and die or warn on generic PVX like Zero, Yes, No...
as this is either an indication we are not using the global PL_sv* or that we should use the PVX from it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants