Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ValidationContext and ExecutionContext use non-core Error types #269

Closed
5 tasks
DaviRain-Su opened this issue Nov 29, 2022 · 1 comment
Closed
5 tasks

Make ValidationContext and ExecutionContext use non-core Error types #269

DaviRain-Su opened this issue Nov 29, 2022 · 1 comment
Assignees
@plafer
Labels
O: new-feature Objective: aims to add new feature S: errors Scope: related to error handlings
Milestone
v0.34.0

Comments

@DaviRain-Su
Copy link
Contributor

DaviRain-Su commented Nov 29, 2022 •
edited by plafer
Loading

Originally comes out of discussion

Currently, our methods in our Context traits return the Error types that are used by our handlers. We should create new Error types for methods in the Context traits. This will allow us to remove error variants that are only meant to be used by hosts (e.g. this).

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@plafer plafer changed the title Make sure there's a Error::Other variant for host methods to use. This PR is getting big enough, we can change host functions in another PR. Make ValidationContext and ExecutionContext use non-core Error types Nov 29, 2022
@plafer plafer added the O: new-feature Objective: aims to add new feature label Nov 29, 2022
@plafer plafer mentioned this issue Dec 6, 2022
Merged
7 tasks
@Farhad-Shabani Farhad-Shabani added the S: errors Scope: related to error handlings label Jan 9, 2023
@plafer plafer mentioned this issue Feb 14, 2023
Open
@plafer plafer self-assigned this Feb 22, 2023
@plafer plafer added this to the v0.30.0 milestone Feb 22, 2023
@Farhad-Shabani Farhad-Shabani modified the milestones: v0.30.0, v0.31.0 Feb 27, 2023
@plafer plafer added this to ibc-rs Feb 27, 2023
@plafer plafer moved this to 🏗️ In Progress in ibc-rs Feb 27, 2023
@Farhad-Shabani Farhad-Shabani modified the milestones: v0.31.0, v0.32.0 Feb 28, 2023
@Farhad-Shabani Farhad-Shabani modified the milestones: v0.32.0, v0.33.0, v0.34.0 Mar 13, 2023
@Farhad-Shabani Farhad-Shabani mentioned this issue Mar 17, 2023
Open
@plafer
Copy link
Contributor

plafer commented Mar 20, 2023

This is now a duplicate of #270

@plafer plafer closed this as not planned Won't fix, can't repro, duplicate, stale Mar 20, 2023
@github-project-automation github-project-automation bot moved this from 🏗️ In Progress to ✅ Done in ibc-rs Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plafer plafer

Labels
O: new-feature Objective: aims to add new feature S: errors Scope: related to error handlings
Projects
ibc-rs
Status: ✅ Done
Milestone
v0.34.0
Development

No branches or pull requests
3 participants
@plafer @DaviRain-Su @Farhad-Shabani