Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent writing of MultiAck if there are still async results #7249

Open
4 tasks
chatton opened this issue Sep 4, 2024 · 0 comments
Open
4 tasks

Prevent writing of MultiAck if there are still async results #7249

chatton opened this issue Sep 4, 2024 · 0 comments
Labels
feat: port-router

Comments

@chatton
Copy link
Contributor

chatton commented Sep 4, 2024

Summary

in the WriteAcknowledgementV2 function here we don't do any protection against setting a packet ack in state if there are still async recvPacket results.

We should error out in this case.

Steps to Reproduce

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
  • Estimate provided
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feat: port-router
Projects
ibc-go
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chatton