-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Website Redesign: Product Page Enhancements #756
base: main
Are you sure you want to change the base?
Conversation
[diff-counting] Significant lines: 25. |
Oh is this CornellGo or Carriage? If we need something feel free to tag the PM in one of their channels and cc me + PM’s + designers. |
This is for Carriage. Right now Carriage has the Coming Soon/blurred image as a place holder and Clement suggested that we should keep it consistent and maybe revert the Cornell Go back to it's blurred image instead of the components we have right now. I was thinking if we could get some images of their features we could switch out the blurred coming soon with those new features (After we've structured it). Also again @Bookie0 feel free to add on/modify this and if either you @andrew032011 or @cchrischen! Have any ideas! Also that sounds like a great Idea! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reached out on Slack. https://cornelldti.slack.com/archives/CJCDQKR0X/p1732888246400639 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks looking good!
just a little problem with the images in the Product page that keep animating even with Reduce Motion on
index !== 0 && !reduceMotion ? getFloatClass(img.direction) : '' | ||
} ${!reduceMotion && img.delay && index !== 0 ? 'floating-delay' : ''}`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm for me it seems like the images still hover slightly even when with Reduce Motion settings on?
the lines don't animate which is expected but i still see the images move around a bit
Screen.Recording.2024-11-30.at.12.53.12.AM.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will look into this! Thanks for catching that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure! lmk when u'd like me to re-review :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm ok so for the sticker effect, James, Vannessa, and I were discussing in this thread here about the sticker effect. I think we all agree that thinner in general is the good direction but we haven't aligned yet on how thin to reduce the stroke.
This is def an improvement, so we can go ahead with your PR, but just wanted to let you know that we might modify it a bit more too.
Awesome I think I might wait on the new design and address it within this PR! Thank you so much for doing that Andrew! |
I think depending on when the design gets out we could merge this in first and take it as a follow-up PR! Just to keep the PR’s small and focused and new.cornelldti.org as close to launch ready as possible. |
Summary
This PR addresses the following changes for the products page
Notion/Figma Link
This was updated after talking with @Bookie0!!
Reduce Motion
Replace logos
Test Plan
Before sizing and spacing:
After Sizing and spacing:
Notes
ProductDisplay
component since each image in the figma has different width limits