Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website Redesign: Product Page Enhancements #756

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JasonMun7
Copy link
Contributor

Summary

This PR addresses the following changes for the products page

  • Utilized reduce Motion to de-activate the animations within the page including the hover/ line fill animation
  • Reduced the overall sticker border for a more cleaner/sleeker look
  • Made Icons of each display a little bigger and Increased space between the View Product and text
  • Fixed overflow issue with images and decreased line usage for descriptions
  • Adjusted width at Have any ideas section

Notion/Figma Link

This was updated after talking with @Bookie0!!
Reduce Motion
Replace logos

Test Plan

  • See svg differences below

Before sizing and spacing:
Screenshot 2024-11-29 at 12 47 58 AM
Screenshot 2024-11-29 at 12 48 32 AM
After Sizing and spacing:
Screenshot 2024-11-29 at 12 46 55 AM
Screenshot 2024-11-29 at 12 27 18 AM

Notes

  • Might need to reach out to Carriage to see if they can send us any designs we can use to update else we can just put cornell go back to the coming soon screen we had before
  • Added an Image classname prop to ProductDisplay component since each image in the figma has different width limits

@JasonMun7 JasonMun7 requested a review from a team as a code owner November 29, 2024 07:49
@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 25.

@JasonMun7 JasonMun7 changed the title Completed Changes for the product page Website Redesign: Product Page Enhancements Nov 29, 2024
@andrew032011
Copy link
Collaborator

andrew032011 commented Nov 29, 2024

Might need to reach out to Carriage to see if they can send us any designs we can use to update else we can just put cornell go back to the coming soon screen we had before

Oh is this CornellGo or Carriage? If we need something feel free to tag the PM in one of their channels and cc me + PM’s + designers.

@JasonMun7
Copy link
Contributor Author

Might need to reach out to Carriage to see if they can send us any designs we can use to update else we can just put cornell go back to the coming soon screen we had before

Oh is this CornellGo or Carriage? If we need something feel free to tag the PM in one of their channels and cc me + PM’s + designers.

This is for Carriage. Right now Carriage has the Coming Soon/blurred image as a place holder and Clement suggested that we should keep it consistent and maybe revert the Cornell Go back to it's blurred image instead of the components we have right now. I was thinking if we could get some images of their features we could switch out the blurred coming soon with those new features (After we've structured it). Also again @Bookie0 feel free to add on/modify this and if either you @andrew032011 or @cchrischen! Have any ideas!

Also that sounds like a great Idea!

Copy link
Collaborator

@andrew032011 andrew032011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-11-29 at 8 41 11 AM Screenshot 2024-11-29 at 8 41 05 AM Screenshot 2024-11-29 at 8 41 02 AM Noticed that a few of these icons aren't aligned with the product name? It looks like they were slightly off in the original too, but if it's easy to adjust that'd be nice!

@andrew032011
Copy link
Collaborator

Might need to reach out to Carriage to see if they can send us any designs we can use to update else we can just put cornell go back to the coming soon screen we had before

Oh is this CornellGo or Carriage? If we need something feel free to tag the PM in one of their channels and cc me + PM’s + designers.

This is for Carriage. Right now Carriage has the Coming Soon/blurred image as a place holder and Clement suggested that we should keep it consistent and maybe revert the Cornell Go back to it's blurred image instead of the components we have right now. I was thinking if we could get some images of their features we could switch out the blurred coming soon with those new features (After we've structured it). Also again @Bookie0 feel free to add on/modify this and if either you @andrew032011 or @cchrischen! Have any ideas!

Also that sounds like a great Idea!

Reached out on Slack. https://cornelldti.slack.com/archives/CJCDQKR0X/p1732888246400639

Copy link
Collaborator

@Bookie0 Bookie0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks looking good!

just a little problem with the images in the Product page that keep animating even with Reduce Motion on

Comment on lines +62 to +63
index !== 0 && !reduceMotion ? getFloatClass(img.direction) : ''
} ${!reduceMotion && img.delay && index !== 0 ? 'floating-delay' : ''}`}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm for me it seems like the images still hover slightly even when with Reduce Motion settings on?

the lines don't animate which is expected but i still see the images move around a bit

Screen.Recording.2024-11-30.at.12.53.12.AM.mov

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will look into this! Thanks for catching that!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure! lmk when u'd like me to re-review :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm ok so for the sticker effect, James, Vannessa, and I were discussing in this thread here about the sticker effect. I think we all agree that thinner in general is the good direction but we haven't aligned yet on how thin to reduce the stroke.

This is def an improvement, so we can go ahead with your PR, but just wanted to let you know that we might modify it a bit more too.

@JasonMun7
Copy link
Contributor Author

JasonMun7 commented Nov 30, 2024

Might need to reach out to Carriage to see if they can send us any designs we can use to update else we can just put cornell go back to the coming soon screen we had before

Oh is this CornellGo or Carriage? If we need something feel free to tag the PM in one of their channels and cc me + PM’s + designers.

This is for Carriage. Right now Carriage has the Coming Soon/blurred image as a place holder and Clement suggested that we should keep it consistent and maybe revert the Cornell Go back to it's blurred image instead of the components we have right now. I was thinking if we could get some images of their features we could switch out the blurred coming soon with those new features (After we've structured it). Also again @Bookie0 feel free to add on/modify this and if either you @andrew032011 or @cchrischen! Have any ideas!

Also that sounds like a great Idea!

Awesome I think I might wait on the new design and address it within this PR! Thank you so much for doing that Andrew!

@andrew032011
Copy link
Collaborator

Might need to reach out to Carriage to see if they can send us any designs we can use to update else we can just put cornell go back to the coming soon screen we had before

Oh is this CornellGo or Carriage? If we need something feel free to tag the PM in one of their channels and cc me + PM’s + designers.

This is for Carriage. Right now Carriage has the Coming Soon/blurred image as a place holder and Clement suggested that we should keep it consistent and maybe revert the Cornell Go back to it's blurred image instead of the components we have right now. I was thinking if we could get some images of their features we could switch out the blurred coming soon with those new features (After we've structured it). Also again @Bookie0 feel free to add on/modify this and if either you @andrew032011 or @cchrischen! Have any ideas!
Also that sounds like a great Idea!

Awesome I think I might wait on the new design and address it within this PR! Thank you so much for doing that Andrew!

I think depending on when the design gets out we could merge this in first and take it as a follow-up PR! Just to keep the PR’s small and focused and new.cornelldti.org as close to launch ready as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants