Member archive reminder cronjob #613
Conversation
|
[diff-counting] Significant lines: 68. |
There was a problem hiding this comment.
This looks great, Patricia! The new cronjob follows the same style as the existing ones, and I like how you used the if checks to incorporate the new schedule with the preexisting ones.
I found that in checks, the one labeled ".github/..." fails. Github actions complains about "invalid workflow file", but I think it should be an easy fix.
| member-archive-reminder: | ||
| if: contains(github.event.schedule, '0 14 20 1,8 *') |
There was a problem hiding this comment.
I think these two lines should be indented one more, so that member-archive-reminder is in jobs, and if is on the same indentation with runs-on like the other two jobs.
There was a problem hiding this comment.
I think is a symptom of not having formatting on the YAML files. We shouldn't have to point these styling issues out :(
| if: contains(github.event.schedule, '0 14 20 1,8 *') | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 |
There was a problem hiding this comment.
In Oscar's PR #607, he updated the workflows, so this should be changed to actions/checkout@v4, along with lines 71 and 75. :)
There was a problem hiding this comment.
you've done an awesome job on this- it's lookin' good! However, I noticed in the cron configuration for 'profile-update-notifications' and 'tec-request-notification,' both jobs are triggered by the same cron schedule (0 23 * * MON), which may cause potential performance bottlenecks. 🐐
patriciaahuang
force-pushed
the
member-archive-reminder
branch
from
194bb2c
to
d624a08
Compare
Fyi this shouldn't be an issue unless we're saying that google/firebase and/or microsoft/github infra can't handle the load 😆 |
Summary
There will be a script made that archives members automatically each semester. This cronjob sends an email to the Ops Leads reminding them to upload the CSV from the returning members survey to archive members at the beginning of each semester.
Notion/Figma Link
https://www.notion.so/Member-archive-script-0540cb5e7d0349c4921f344b1875387e?pvs=4
Test Plan
Ran
yarn ts-node --transpile-only scripts/send-member-archive-reminder.tslocally.Breaking Changes
Need to add an ops-leads collection with emails as the documents in the prod DB.