Changed achievements cell UI #231
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e numbers - Adjusted progress bar width to dynamically scale based on the number of digits in total points, achievements, etc., providing better visual alignment. - Implemented formatting to shorten large numbers (e.g., 1500 becomes 1.5K) for improved readability.
|
|
|
[diff-counting] Significant lines: 114. |
…UI changes to profile page.
Shengle-Dai
reviewed
Nov 17, 2024
There was a problem hiding this comment.
Nice try to shorten the number if it is greater than 1000 and make the width to have dynamic width!
However, I think it'll be better to make the progress bar length consistent for all achievements (maybe keep the 0.43 as the multiplier). Also, remember to follow the PR template and remove the unused PR template sections!
Jcheng777
changed the title
BrianLa0616
requested changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e numbers
Summary
This pull request is the first step towards implementing achievement cell UI
Test Plan