Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting started #1

Open
wesleytodd opened this issue Feb 27, 2021 · 3 comments
Open

Getting started #1

wesleytodd opened this issue Feb 27, 2021 · 3 comments

Comments

@wesleytodd
Copy link
Contributor

Based on our conversation today on the WG call, I took an initial go at writing a new git bump recommender with the new parser. If folks want I can push a placeholder and then re-open this work as a PR, but I didn't want to just let it sit on my computer tonight. Happy to take feedback in whatever form works best for you all.

cc @byCedric @bcoe @damianopetrungaro

@damianopetrungaro
Copy link
Member

@wesleytodd
Silly one from a non-js folk, does JS have an idiomatic way of adding Table-Driven Tests or Parameterized tests?

In this way, we could automate part of the test by simply adding some use cases.

@wesleytodd
Copy link
Contributor Author

wesleytodd commented Apr 12, 2021

Hey @damianopetrungaro, not silly but also not one I have a clear answer for. I have seen many test suites with setup's like this in JS projects, but I doubt you could find enough consensus to call it idiomatic. Personally I don't have a strong opinion on how we write tests for these components. If anyone (you or anyone else) have those I am happy to follow whatever the team decides is best.


Separate topic, next steps for this:

  1. Add support for taking parsed or unparsed commits as input (likely required for integration with things like Release Please)
  2. Documentation
  3. (maybe based on above) More tests
  4. Revert commits (see todo in source)
  5. Commit filter (See todo in source)
  6. Nested commits (see todo)
  7. ...?

Anything else big we are missing here?

@damianopetrungaro
Copy link
Member

@wesleytodd I think it's good as the first step 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants