[5.2-rhel] libpod: fix volume copyup with idmap | convert owner IDs only with :idmap #24591
Conversation
if idmap is specified for a volume, reverse the mappings when copying up from the container, so that the original permissions are maintained. Closes: containers#23467 Signed-off-by: Giuseppe Scrivano <[email protected]> (cherry picked from commit 3ae1568)
Signed-off-by: Ed Santiago <[email protected]> (cherry picked from commit 7bb3b83)
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-ci
bot
added
the
do-not-merge/release-note-label-needed
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Ephemeral COPR build failed. @containers/packit-build please check. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@TomSweeneyRedHat Do we need z-stream backport request cards before merging? |
|
@Luap99 at this point, we don't need a Zstream card for 5.2, since 5.2 is top of tree in RHEL and this is a backport from main, we can just fix it with the existing Jira card. Good question though, you made me think for a bit. |
convert the owner UID and GID into the user namespace only when ":idmap" mount is used. This changes the behaviour of :idmap with an empty volume. Now the existing directory ownership is copied up as in the other case. Closes: containers#23347 Closes: https://issues.redhat.com/browse/RHEL-67842 Signed-off-by: Giuseppe Scrivano <[email protected]> (cherry picked from commit 4323252) Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
force-pushed
the
backport-5.2-idmap
branch
from
f1b1112
to
d3fbb51
Compare
backport of:
Fixes: https://issues.redhat.com/browse/RHEL-67842