Don't use root as default user for exec_run
#431
Conversation
|
Hardcoding to the "root" user will ignore the user within the IMage, which I believe is wrong, so this seems like the proper change. |
|
Tests are blowing up, though. |
|
Looks unrelated to my changes? |
Thanks @aparcar for the pr We have the same pylint issue on another PR. I am taking a look but can't see what's the cause of the issue at a first glance. I am ok with the change but let's see if the test's flake disappears. Will come back later to this. |
|
/approved I have no idea why gating tests are failing? @jwhonce @lsm5 @umohnani8 Do you know what is going on? |
|
@rhatdan I am on it, PR with a fix in few minutes Quick explaination of whwat's happening. Currently, pylint is flaky. With this assumption, we know that sometimes pylint can be right even though it did not complain in the past for no apparent reason. While this can seem unrelated to this PR it could still be a perfectly valid complaint such for |
|
Linking for ref. Hopefully will see green lights |
|
@aparcar tests should be good now if you want to rebase and test it |
Instead use whatever user the container uses per default, which might be `root` but may also be something else. This avoids manually figuring out the default user in case some files inside the container are specifically owned by a non-root user. Signed-off-by: Paul Spooren <[email protected]>
|
Rebased |
|
LGTM |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aparcar, inknos, lsm5 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Instead use whatever user the container uses per default, which might be
rootbut may also be something else. This avoids manually figuring out the default user in case some files inside the container are specifically owned by a non-root user.