Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ModelUtils.ts should not contain process execution logic #1809

Open
axel7083 opened this issue Sep 30, 2024 · 0 comments · May be fixed by #1810
Open

ModelUtils.ts should not contain process execution logic #1809

axel7083 opened this issue Sep 30, 2024 · 0 comments · May be fixed by #1810
Assignees
@axel7083
Labels
kind/enhancement ✨ New feature or request sprint/unplanned technical-debt

Comments

@axel7083
Copy link
Contributor

Is your enhancement related to a problem? Please describe

Currently the packages/backend/src/utils/modelsUtils.ts has two method which should not be in an utility file

podman-desktop-extension-ai-lab/packages/backend/src/utils/modelsUtils.ts

Line 50 in e2d5a2e

export async function isModelUploaded(machine: string, modelInfo: ModelInfo): Promise<boolean> {

podman-desktop-extension-ai-lab/packages/backend/src/utils/modelsUtils.ts

Line 66 in e2d5a2e

export async function deleteRemoteModel(machine: string, modelInfo: ModelInfo): Promise<void> {

Those two method uses the process api exposed by the podman-desktop core. They are getting the podman executable through getPodmanCli which should be deprecated since podman-desktop/podman-desktop#8891 has been merged

Describe the solution you'd like

We need to support the new podman-desktop/podman-desktop#8891 and properly manage the legacy support (version < 1.13).

The logic method should be moved to the PodmanConnection class.

Describe alternatives you've considered

No response

Additional context

This work is required for #1591
@axel7083 axel7083 self-assigned this Sep 30, 2024
@axel7083 axel7083 linked a pull request Sep 30, 2024 that will close this issue
Draft
1 task
@axel7083 axel7083 moved this to 🚥 In Review in Podman Desktop Planning Oct 1, 2024
@axel7083 axel7083 moved this from 🚥 In Review to ⏱Postponed in Podman Desktop Planning Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@axel7083 axel7083

Labels
kind/enhancement ✨ New feature or request sprint/unplanned technical-debt
Projects
Podman Desktop Planning
Status: ⏱Postponed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: improve podman cli execution for models axel7083/ai-studio
1 participant
@axel7083