Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taskScss does not handle SCSS imports #881

Closed
AronNovak opened this issue Jul 15, 2019 · 2 comments
Closed

taskScss does not handle SCSS imports #881

AronNovak opened this issue Jul 15, 2019 · 2 comments

Comments

@AronNovak
Copy link

Steps to reproduce

$result = $this->taskScss([
      self::THEME_BASE . '/scss/style.scss' => self::THEME_BASE . '/css/style.css',
    ])
      ->setFormatter($formatter)
      ->importDir(['scss'])
      ->run();

scss/style.scss:

@import "variables";
@import "pages/homepage";

Expected behavior

The @import shall be resolved in the output CSS.

Actual behavior

The @import directive appears as-is in the compiled CSS.

System Configuration

php -v
PHP 7.2.19 (cli) (built: May 29 2019 07:14:35) ( NTS )
Copyright (c) 1997-2018 The PHP Group
Zend Engine v3.2.0, Copyright (c) 1998-2018 Zend Technologies
    with Zend OPcache v7.2.19, Copyright (c) 1999-2018, by Zend Technologies
    with Xdebug v2.7.2, Copyright (c) 2002-2019, by Derick Rethans

Fedora 29:

5.1.16-200.fc29.x86_64 #1
@AronNovak
Copy link
Author

Likely root cause: leafo/scssphp#402

@AronNovak
Copy link
Author

Actually the importPath wasn't properly defined, it was an incorrect relative path. With the absolute path, it works nicely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant