Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mujoco v2.3.0 #10

Merged
merged 25 commits into from
Nov 29, 2022
Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Pending Dependency Version Updates

Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.

Name Upstream Version Current Version
clangdev 15.0.3 Anaconda-Server Badge
mujoco 2.3.0 Anaconda-Server Badge

Dependency Analysis

We couldn't run dependency analysis due to an internal error in the bot. :/ Help is very welcome!

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3273409815, please use this URL for debugging.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@traversaro
Copy link
Contributor

traversaro commented Oct 27, 2022

This release has a new plugin feature that we should be able to verify that it is working, that it is not trivial given how the location of the plugins is passed to the library. In particular, my first understanding is that plugins at the moment will not work at all if one uses mujoco as a C++ library, they just work for the Python bindings and the simulate program (this is because the code to find the plugins is not in the C++ library, but rather in the simulate program, see google-deepmind/mujoco@e250ff0 or in the python bindings https://github.com/deepmind/mujoco/blob/2.3.0/python/mujoco/__init__.py#L61).

Related commits:

Related issues:

@traversaro
Copy link
Contributor

In particular, my first understanding is that plugins at the moment will not work at all if one uses mujoco as a C++ library,

I explicitly asked this upstream at google-deepmind/mujoco#554 .

@traversaro
Copy link
Contributor

In particular, my first understanding is that plugins at the moment will not work at all if one uses mujoco as a C++ library,

I explicitly asked this upstream at deepmind/mujoco#554 .

Yes, for the time being there is no support for using plugins out of the box when using mujoco as a C++ library,

@traversaro traversaro closed this Nov 26, 2022
@traversaro traversaro reopened this Nov 26, 2022
@traversaro
Copy link
Contributor

macOS is failing with:

2022-11-26T15:52:44.6279840Z FAILED: CMakeFiles/mujoco.dir/src/engine/engine_plugin.cc.o 
2022-11-26T15:52:44.6374130Z /Users/runner/miniforge3/conda-bld/mujoco_1669477660814/_build_env/bin/x86_64-apple-darwin13.4.0-clang++ -DCCD_STATIC_DEFINE -DEIGEN_MPL2_ONLY -DMUJOCO_DLL_EXPORTS -D_GNU_SOURCE -Dmujoco_EXPORTS -I/Users/runner/miniforge3/conda-bld/mujoco_1669477660814/work/include -I/Users/runner/miniforge3/conda-bld/mujoco_1669477660814/work/src -I/Users/runner/miniforge3/conda-bld/mujoco_1669477660814/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/include/libqhull_r -I/Users/runner/miniforge3/conda-bld/mujoco_1669477660814/work/build/_deps/tinyobjloader-src -march=core2 -mtune=haswell -mssse3 -ftree-vectorize -fPIC -fPIE -fstack-protector-strong -O2 -pipe -stdlib=libc++ -fvisibility-inlines-hidden -fmessage-length=0 -isystem /Users/runner/miniforge3/conda-bld/mujoco_1669477660814/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/include -fdebug-prefix-map=/Users/runner/miniforge3/conda-bld/mujoco_1669477660814/work=/usr/local/src/conda/mujoco-cxx-2.3.0 -fdebug-prefix-map=/Users/runner/miniforge3/conda-bld/mujoco_1669477660814/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl=/usr/local/src/conda-prefix -O3 -DNDEBUG -flto=thin -isysroot /Applications/Xcode_13.2.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk -mmacosx-version-min=10.9 -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -fdata-sections -ffunction-sections -mmacosx-version-min=10.12 -Werror=partial-availability -Werror=unguarded-availability -Wall -Werror -std=c++17 -MD -MT CMakeFiles/mujoco.dir/src/engine/engine_plugin.cc.o -MF CMakeFiles/mujoco.dir/src/engine/engine_plugin.cc.o.d -o CMakeFiles/mujoco.dir/src/engine/engine_plugin.cc.o -c /Users/runner/miniforge3/conda-bld/mujoco_1669477660814/work/src/engine/engine_plugin.cc
2022-11-26T15:52:44.6482280Z /Users/runner/miniforge3/conda-bld/mujoco_1669477660814/work/src/engine/engine_plugin.cc:266:21: error: aligned allocation function of type 'void *(std::size_t, std::align_val_t, const std::nothrow_t &) noexcept' is only available on macOS 10.14 or newer
2022-11-26T15:52:44.6484200Z       table->next = new(std::nothrow) PluginTable;
2022-11-26T15:52:44.6581470Z                     ^
2022-11-26T15:52:44.6596410Z /Users/runner/miniforge3/conda-bld/mujoco_1669477660814/work/src/engine/engine_plugin.cc:266:21: note: if you supply your own aligned allocation functions, use -faligned-allocation to silence this diagnostic
2022-11-26T15:52:44.6688430Z /Users/runner/miniforge3/conda-bld/mujoco_1669477660814/work/src/engine/engine_plugin.cc:266:21: error: aligned deallocation function of type 'void (void *, std::align_val_t, const std::nothrow_t &) noexcept' is only available on macOS 10.14 or newer
2022-11-26T15:52:44.6784860Z       table->next = new(std::nothrow) PluginTable;
2022-11-26T15:52:44.6799590Z                     ^
2022-11-26T15:52:44.6893260Z /Users/runner/miniforge3/conda-bld/mujoco_1669477660814/work/src/engine/engine_plugin.cc:266:21: note: if you supply your own aligned allocation functions, use -faligned-allocation to silence this diagnostic
2022-11-26T15:52:44.6987200Z 2 errors generated.

@traversaro
Copy link
Contributor

@conda-forge-admin please rerender

@traversaro traversaro added the automerge Merge the PR when CI passes label Nov 26, 2022
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: failed

Thus the PR was not passing and not merged.

@github-actions github-actions bot removed the automerge Merge the PR when CI passes label Nov 28, 2022
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@traversaro traversaro merged commit fda44f2 into conda-forge:main Nov 29, 2022
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 2.3.0_h4ec38a branch November 29, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants