Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peptide sequence and modification locations are not updated for decoys #9

Open
hbarsnes opened this issue Jun 8, 2020 · 2 comments
Labels

Comments

@hbarsnes
Copy link
Member

hbarsnes commented Jun 8, 2020

When generating decoy spectra the peptide sequence and modification locations are not updated. Thus the spectrum returned by com.compomics.coss.controller.decoyGeneration.GetDecoySpectrum will have the same peptide sequence and modifications as the target spectrum, which makes it impossible to separate the two in downstream post-processing.

@hbarsnes hbarsnes added the bug label Jun 8, 2020
@Genet-Abay
Copy link
Contributor

Thanks again for this information. Now I have updated the sequence and modification information for the decoy spectra library generated. While decoy generation using random sequence has still an issue which I still need to figure out, the reverse sequence method works perfectly. Sine no big difference between the two decoy generation methods you can use reverse sequence method for the time being.

@hbarsnes
Copy link
Member Author

hbarsnes commented Jun 19, 2020

Thanks! I will test as soon as the issue with the missing rows in the text export has been solved: #8

@hbarsnes hbarsnes reopened this Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants