Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SKUs and SKU Lists break navigation #154

Open
maxmezzomo opened this issue Nov 16, 2024 · 0 comments · May be fixed by #158
Open

SKUs and SKU Lists break navigation #154

maxmezzomo opened this issue Nov 16, 2024 · 0 comments · May be fixed by #158
Labels
bug Something isn't working

Comments

@maxmezzomo
Copy link

maxmezzomo commented Nov 16, 2024

Describe the bug

on /apps clicking either SKUs or SKU Lists seems to break navigation, specifically back button navigation. Additionally both seem to add 2 entries to history which may be the issue.

On a related note, is there a motivation for rendering buttons over anchor links; which would be in my opinion a more pleasant user experience.

To Reproduce

  1. On dashboard app home /apps
  2. No particular config
  3. Click on SKUs or SKU Lists button
  4. On /skus/list try to navigate back in browser
  5. If bug -> navigation should stay on /skus/list

System

No response

Additional context

If useful, did some digging, and I think the following redirect causes the issues

<Redirect to={appRoutes.list.path} />

perhaps the location should be replaced so you avoid getting caught in infinite redirect loop if trying to go back in history.

@maxmezzomo maxmezzomo added the bug Something isn't working label Nov 16, 2024
@maxmezzomo maxmezzomo linked a pull request Nov 18, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant