Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove diagrams directory #2

Open
jeff-matthews opened this issue Jul 9, 2019 · 3 comments
Open

Remove diagrams directory #2

jeff-matthews opened this issue Jul 9, 2019 · 3 comments
Assignees

Comments

@jeff-matthews
Copy link
Contributor

jeff-matthews commented Jul 9, 2019

Per team conversation on 7/9/19:

  • The infographics-library repo should only contain shared infographic components/icons
  • draw.io source files can be stored in the same format we use for presentation (SVG)
  • There's no need to store diagrams in a separate "diagrams" directory
  • Keeps these files in the same repo as devdocs or docs
  • We should move sketch files to internal storage (e.g., SharePoint)
  • The "Icons" directory is an appropriate use of the infographics repo
@bdenham
Copy link
Collaborator

bdenham commented Jul 9, 2019

Sounds good, but if we create graphics in draw.io, I’m not sure that SVG files can be imported and edited with draw.io as needed for updates. The drawio xml format is the actual source file for those graphics, so they may need to be stored with the exported SVG files.

@jeff-matthews
Copy link
Contributor Author

Thanks @bdenham. @dshevtsov seemed convinced that we could use SVG for both source and output, but if that's not the case, we need to confirm.

@bdenham
Copy link
Collaborator

bdenham commented Jul 9, 2019

Got it. I’ll do some tests later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants