forked from tobi/delayed_job
-
Notifications
You must be signed in to change notification settings - Fork 954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for worker pools that exclude specific queues #1148
Open
njakobsen
wants to merge
8
commits into
collectiveidea:master
Choose a base branch
from
combinaut:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Mar 18, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 235fc2c - Browse repository at this point
Copy the full SHA 235fc2cView commit details
Commits on Mar 19, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 88ad588 - Browse repository at this point
Copy the full SHA 88ad588View commit details
Commits on Mar 3, 2021
-
Co-authored-by: Nicholas Jakobsen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d30def5 - Browse repository at this point
Copy the full SHA d30def5View commit details -
Co-authored-by: Nicholas Jakobsen <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3e39646 - Browse repository at this point
Copy the full SHA 3e39646View commit details
Commits on Mar 4, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 48e5484 - Browse repository at this point
Copy the full SHA 48e5484View commit details -
Allow per worker queue exclusions in pools
The addition of `exclude_specified_queues` allowed all specified queues to be treated as exclusions, implying that all jobs in those queues not be handled by the workers. However, this only allows application of this behaviour globally. What we want is the ability to create two or more pools, where some pools handle jobs from the given queues and other pools handle jobs that are not from the given queues. To implement this, we check if the `exclude_specified_queues` is not set and treat this as a request for automatic detection of exclusions. By adding a "!" to the beginning of a queue list, only the workers that handle that list of queues will behaves as if the `exclude_specified_queues` flag had been set.
Configuration menu - View commit details
-
Copy full SHA for 1301f01 - Browse repository at this point
Copy the full SHA 1301f01View commit details
Commits on Aug 26, 2021
-
Configuration menu - View commit details
-
Copy full SHA for bfafebf - Browse repository at this point
Copy the full SHA bfafebfView commit details
Commits on Feb 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 329beaf - Browse repository at this point
Copy the full SHA 329beafView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.