Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement cliques in CglProbing #37

Open
svigerske opened this issue Mar 2, 2019 · 1 comment
Open

Implement cliques in CglProbing #37

svigerske opened this issue Mar 2, 2019 · 1 comment
Labels
CglProbing enhancement New feature or request

Comments

@svigerske
Copy link
Member

Issue created by migration from Trac.

Original creator: @LouHafer

Original creation time: 2011-02-19 00:43:14

Assignee: @LouHafer

Turns out that the clique code in CglProbing has been unused since April 2008 and never really worked. As part of the ongoing rewrite of CglProbing ([branches/CglWorking101215/src/CglProbing])) I've just lopped out all code associated with cliques, snapshots, and mode 0 (these are all intertwined). When someone comes back to get this working, the place to start is d7c1744662, the last revision that still had all the code.

@svigerske svigerske added CglProbing enhancement New feature or request major labels Mar 2, 2019
@svigerske
Copy link
Member Author

Comment by @LouHafer created at 2011-02-24 22:02:45

The followup to 8e22c73 (rough cut for removal of generalised cliques from CglProbing) is 15efc38 and the immediately previous commits, which remove CglTreeProbingInfo. If generalised cliques are gone, there's no justification for CglTreeProbingInfo. There was a lot of collateral damage to repair. CglTreeProbingInfo and generalised clique code were inserted in far too many places. CglGeneralisedClique.hpp preserves a tiny bit required by CglKnapsackCover.

@svigerske svigerske removed the major label Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CglProbing enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant