Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename headers to variables or something similar #21

Open
yichern opened this issue Nov 1, 2022 · 0 comments
Open

Rename headers to variables or something similar #21

yichern opened this issue Nov 1, 2022 · 0 comments
Labels
refactor Better design while preserving functionality

Comments

@yichern
Copy link
Contributor

yichern commented Nov 1, 2022

From #6 (comment) and #6 (comment)

I'm also not very settled on the naming of headers because headers seems to suggest something like "Math Teacher Bot" not "bot" (ie. the value of a field, not the name of the field itself). Would a better way to name it be variables (so: variable value and variable name)? This is probably better implemented in a separate PR

re: headers -- what about header_names or header_keys? In any case, agreed that it is better done in a refactor PR later IMO.

Do we want to rename headers to variables?
@yichern yichern added the refactor Better design while preserving functionality label Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Better design while preserving functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yichern