-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade frontend npm dependencies #1634
Comments
@monocle Nice! Feel free to submit PRs one bullet at a time (or even in more granular chunks). My guess is swapping moment.js to dayjs would be a nice chunk. |
In trying to upgrade the dependencies, I've run into a lot of little fixes. Here is my fork with the commits so far. The commits are pretty atomic. I could rebase if that would be better. Questions:
|
I realized I missed this post. There should be a husky hook in this repository that you can run or make into a git commit hook. In general, smaller chunks are preferable at first. Feel free to reach out wherever. Tagging me will make it easier for me to follow @monocle. |
@KentShikama Would it be okay to change our node image to 18-bullseye? I think we need to upgrade node for the other package upgrades. Also, I'm trying to use VSCode's dev container feature to access the node_modules (ex. prettier) within the Docker container and they have a node 18 bullseye version for their typescript-node image. |
Sure! @monocle |
Upgrade react-router-dom to 6.11.0. Closes #1634
Per the Slack discussion, I'll start working on this.
Notes:
Reach UI is not currrently maintained. This is blocking from updating React to 18x. The Reach UI team mentions alternative:
It would probably be better for long term maintenance just to use plain HTML/CSS.
The text was updated successfully, but these errors were encountered: