Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade frontend npm dependencies #1634

Closed
2 of 3 tasks
monocle opened this issue Dec 20, 2022 · 5 comments · Fixed by #1698
Closed
2 of 3 tasks

Upgrade frontend npm dependencies #1634

monocle opened this issue Dec 20, 2022 · 5 comments · Fixed by #1698
Assignees

Comments

@monocle
Copy link
Contributor

monocle commented Dec 20, 2022

Per the Slack discussion, I'll start working on this.

  • switch from node-sass (deprecated) to dart-sass (current primary implementation)
  • upgrade all dependencies to current
  • switch out of moment.js per their recommendation

Notes:
Reach UI is not currrently maintained. This is blocking from updating React to 18x. The Reach UI team mentions alternative:

It would probably be better for long term maintenance just to use plain HTML/CSS.

@KentShikama
Copy link
Member

@monocle Nice! Feel free to submit PRs one bullet at a time (or even in more granular chunks). My guess is swapping moment.js to dayjs would be a nice chunk.

@monocle
Copy link
Contributor Author

monocle commented Dec 22, 2022

In trying to upgrade the dependencies, I've run into a lot of little fixes. Here is my fork with the commits so far. The commits are pretty atomic. I could rebase if that would be better.

Questions:

  • I'm using Prettier through VS Code and some of the commits have whitespace changes due to that. Is there some configuration that I should set on my local machine to avoid those whitespace changes?
  • The changes are building up and other things still need to be upgraded. Should I just keep going in the same branch? Or should we try to merge the other non-upgrade related commits separately?
  • I've noticed some minor content issues that I have not fixed yet. Should we fix those and move them into production before the other things?
  • To avoid spamming you and the Slack channel, I'm planning to tee up things, including issues, in my fork. Let me know if you'd like to be more in the loop with anything and, if so, what the prefer communication method would be.

@KentShikama
Copy link
Member

I realized I missed this post. There should be a husky hook in this repository that you can run or make into a git commit hook. In general, smaller chunks are preferable at first. Feel free to reach out wherever. Tagging me will make it easier for me to follow @monocle.

@monocle
Copy link
Contributor Author

monocle commented Jan 13, 2023

@KentShikama Would it be okay to change our node image to 18-bullseye? I think we need to upgrade node for the other package upgrades. Also, I'm trying to use VSCode's dev container feature to access the node_modules (ex. prettier) within the Docker container and they have a node 18 bullseye version for their typescript-node image.

@KentShikama
Copy link
Member

Sure! @monocle

@monocle monocle self-assigned this Jan 23, 2023
@monocle monocle linked a pull request May 3, 2023 that will close this issue
KentShikama added a commit that referenced this issue May 4, 2023
Upgrade react-router-dom to 6.11.0. Closes #1634
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants