Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release note for bug fix for iterator over file sinks #19180

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

shannonbradshaw
Copy link
Contributor

@arjunmahishi and @smcvey because there was no release note specified for this change, would you please offer any guidance you have on making the release note I've drafted here clearer or more specific?

… iterator over file sinks to include buffered sinks.
Copy link

Files changed:

Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit f355f02
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/6745f94eaf74740008da9c78

Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit f355f02
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/6745f94ea166170008ee4ea6

Copy link

netlify bot commented Nov 26, 2024

Netlify Preview

Name Link
🔨 Latest commit f355f02
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/6745f94e39454a00080bb850
😎 Deploy Preview https://deploy-preview-19180--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@florence-crl florence-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending suggestion.

@@ -55,6 +55,7 @@ Release Date: September 25, 2024
- Fixed a bug where the [`require_explicit_primary_keys` session variable]({% link v24.1/session-variables.md %}#require-explicit-primary-keys) would aggressively prevent all [`CREATE TABLE`]({% link v24.1/create-table.md %}) statements from working. [#129907][#129907]
- Fixed a slow-building memory leak when using [Kerberos authentication]({% link v24.1/gssapi_authentication.md %}). [#130318][#130318]
- Fixed a potential memory leak in [changefeeds]({% link v24.1/change-data-capture-overview.md %}) using a [cloud storage sink]({% link v24.1/changefeed-sinks.md %}#cloud-storage-sink). The memory leak could occur if both the cluster settings [`changefeed.fast_gzip.enabled`]({% link v24.1/cluster-settings.md %}#setting-changefeed-fast-gzip-enabled) and [`changefeed.cloudstorage.async_flush.enabled`]({% link v24.1/cluster-settings.md %}) are set to `true` and the changefeed received an error while attempting to write to the cloud storage sink. [#130626][#130626]
- Fixed a bug that prevented buffered file sinks from being included when iterating over all file sinks. This led to problems such as the `debug zip` command not being able to fetch logs for a cluster where buffering was enabled. [#130158][#130158]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion for all versions:

Suggested change
- Fixed a bug that prevented buffered file sinks from being included when iterating over all file sinks. This led to problems such as the `debug zip` command not being able to fetch logs for a cluster where buffering was enabled. [#130158][#130158]
- Fixed a bug that incorrectly excluded buffered file sinks when iterating over all file sinks. This led to problems such as the `debug zip` command not being able to fetch logs for a cluster where buffering was enabled. [#130158][#130158]

@shannonbradshaw shannonbradshaw merged commit f266cbb into main Nov 26, 2024
6 checks passed
@shannonbradshaw shannonbradshaw deleted the file-sink-bug-fix branch November 26, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants