-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release note for bug fix for iterator over file sinks #19180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… iterator over file sinks to include buffered sinks.
Files changed:
|
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
smcvey
approved these changes
Nov 26, 2024
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify site configuration. |
florence-crl
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm pending suggestion.
@@ -55,6 +55,7 @@ Release Date: September 25, 2024 | |||
- Fixed a bug where the [`require_explicit_primary_keys` session variable]({% link v24.1/session-variables.md %}#require-explicit-primary-keys) would aggressively prevent all [`CREATE TABLE`]({% link v24.1/create-table.md %}) statements from working. [#129907][#129907] | |||
- Fixed a slow-building memory leak when using [Kerberos authentication]({% link v24.1/gssapi_authentication.md %}). [#130318][#130318] | |||
- Fixed a potential memory leak in [changefeeds]({% link v24.1/change-data-capture-overview.md %}) using a [cloud storage sink]({% link v24.1/changefeed-sinks.md %}#cloud-storage-sink). The memory leak could occur if both the cluster settings [`changefeed.fast_gzip.enabled`]({% link v24.1/cluster-settings.md %}#setting-changefeed-fast-gzip-enabled) and [`changefeed.cloudstorage.async_flush.enabled`]({% link v24.1/cluster-settings.md %}) are set to `true` and the changefeed received an error while attempting to write to the cloud storage sink. [#130626][#130626] | |||
- Fixed a bug that prevented buffered file sinks from being included when iterating over all file sinks. This led to problems such as the `debug zip` command not being able to fetch logs for a cluster where buffering was enabled. [#130158][#130158] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion for all versions:
Suggested change
- Fixed a bug that prevented buffered file sinks from being included when iterating over all file sinks. This led to problems such as the `debug zip` command not being able to fetch logs for a cluster where buffering was enabled. [#130158][#130158] | |
- Fixed a bug that incorrectly excluded buffered file sinks when iterating over all file sinks. This led to problems such as the `debug zip` command not being able to fetch logs for a cluster where buffering was enabled. [#130158][#130158] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@arjunmahishi and @smcvey because there was no release note specified for this change, would you please offer any guidance you have on making the release note I've drafted here clearer or more specific?