Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating c++ default standard to c++20 for 14.1.X #45432

Closed
smuzaffar opened this issue Jul 11, 2024 · 11 comments
Closed

Updating c++ default standard to c++20 for 14.1.X #45432

smuzaffar opened this issue Jul 11, 2024 · 11 comments

Comments

@smuzaffar
Copy link
Contributor

Hi,
We are ready to update the default c++ standard to c++20 for 14.1.X. cms-sw/cmsdist#9288 changes the default to c++20. There are few known issues with it

Note that we do not build 14.1.0 releases for gcc13 yet, so we can let that IB fail and wait for cuda update. We can also apply the gcc patch on top of existing 13.2.1 which should allow to build gcc 13 (except the existing array-bound error #45340) and then update to gcc 13.3.0 when cuda supports it. This requires two full rebuild of our externals.

I prefer that we move to GCC 13.3.0 and wait for cuda update

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 11, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

A new Issue was created by @smuzaffar.

@Dr15Jones, @antoniovilela, @makortel, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

I prefer that we move to GCC 13.3.0 and wait for cuda update

@fwyzard , do you have any preference ?

@fwyzard
Copy link
Contributor

fwyzard commented Jul 11, 2024

Depends if we want to have a gcc13 14.1.0 release.

14.1.0 is going to be used for the heavy ions data taking, so I would prefer to switch to a newer CUDA version only after an extensive validation.

Given that such new CUDA version does not exist yet, I'm not very comfortable with having to switch any time soon.

On the other hand, if we do not care about having a gcc13 14.1.0 release, and we can leave the IBs failing into the next release cycle, then I don't have any reason to object.

@smuzaffar
Copy link
Contributor Author

There is no urgency to move to gcc 13 for 14.1.0 , atleast there are no plans yet to use it for cmssw production architecture.

OK, to be on the safe side, we can stay with gcc 13.2.1 + gcc-mirror/gcc@96482ff to atleast have working IBs.

@smuzaffar
Copy link
Contributor Author

Today's 11h00 will be built with c++20

@makortel
Copy link
Contributor

assign core

@cmsbuild
Copy link
Contributor

New categories assigned: core

@Dr15Jones,@makortel,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks

@makortel
Copy link
Contributor

makortel commented Aug 9, 2024

@smuzaffar Do we have any reason to keep this issue open, or could it be closed?

@smuzaffar
Copy link
Contributor Author

+core

@makortel , this is complete

@cmsbuild
Copy link
Contributor

This issue is fully signed and ready to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants