Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make addpackage check the current dir is inside of CMSSW_BASE #29

Open
slava77 opened this issue Aug 2, 2013 · 3 comments
Open

make addpackage check the current dir is inside of CMSSW_BASE #29

slava77 opened this issue Aug 2, 2013 · 3 comments

Comments

@slava77
Copy link
Contributor

slava77 commented Aug 2, 2013

I sometimes forget to cmsenv before running git, after switching from another release area.
Current behavior of cms git tools (cms-addpkg) will make changes
to the old release area, making silently quite a mess.
Please add a check that the current dir is inside of CMSSW_BASE

@ktf
Copy link
Contributor

ktf commented Aug 2, 2013

The code is there, albeit commented. The problem is that at FNAL they have the bad habit of creating the workarea in one place and then work in a directory mounted in a different place which makes that code (and the solution you propose) fail. I'll try to think something smarter.

@slava77
Copy link
Contributor Author

slava77 commented Aug 3, 2013

On 8/2/13 8:40 PM, Giulio Eulisse wrote:

The code is there, albeit commented. The problem is that at FNAL they
have the bad habit of creating the workarea in one place and then work
in a directory mounted in a different place which makes that code (and
the solution you propose) fail. I'll try to think something smarter.

Ciao Giuliio,

If we don't want to do it by default,
could you please add a switch/option.
I will just need to get a habit to use that option.

Thanks

    --slava


Reply to this email directly or view it on GitHub
#29 (comment).


Vyacheslav (Slava) Krutelyov
TAMU: Physics Dept Texas A&M MS4242, College Station, TX 77843-4242
CERN: 42-R-027
AIM/Skype: siava16 googleTalk: [email protected]
(630) 291-5128 Cell (US) +41 76 275 7116 Cell (CERN)


@ghost ghost assigned ktf Aug 9, 2013
@slava77
Copy link
Contributor Author

slava77 commented Oct 25, 2014

ping

I find that it can be very creative: I deleted the test release area, started a new one and forgot to do cmsenv. What do you know, there was no failure doing git cms-init etc and it recreated back my old release area tree (well, only the src part of it).
At least no harm in this case

@ktf ktf removed their assignment Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants