-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow custom forcefield to be used in planckton-flow #21
Comments
Hi @gwenwhite, just to clarify this issue a little further, this may be two separate problems:
|
" know you are working on this right now :) Once this is finished we can submit a PR to gaff-foyer or antechamber to update the gaff repo, and update it in planckton." Wouldn't this require some testing via running simulations with the new parameters to understand if the new parameters make sense? As written, planckton will accept anything that is a foyer FF object, so planckton allows the user to use an edited/customized version of gaff. If this feature is already in planckton then it would be nice to be able to access it via planckton flow as planckton-flow essentially serves as an access point to planckton. And I think moving away from single-use custom forcefields in favor of version controlled forcefields is kind of subjective. I think some people prefer working with a trimmed down focefield file that doesn't contain any more infoormation than needed for whatever project they are working on. |
Also, I think cmelab/planckton#59 is more about removing the extra logic/steps of checking a file name, and having the gaff_custom file essentially hard coded in more-so than about moving away from custom focefields in general. |
Right now planckton-flow does not allow custom forcefields to be made. It would be nice to change this for new molecules we create in mbuild.
The text was updated successfully, but these errors were encountered: