Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make acl id parameter a boolean (enable/disable) #13

Open
philwinder opened this issue Jan 18, 2019 · 2 comments
Open

Make acl id parameter a boolean (enable/disable) #13

philwinder opened this issue Jan 18, 2019 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@philwinder
Copy link
Contributor

There is a parameter that allows you to pass in an externally created NACL id. If you do, then you get the horrible "cannot compute count" error, because it is an interpolated value.

But after looking at the code, it's not actually used anywhere. It's just used as a boolean. For example here: https://github.com/cloudposse/terraform-aws-multi-az-subnets/blob/master/public.tf#L36

So I've just passed in a string named "disable" and it works as intended.

Can you change it to be a boolean? Like the ngw enable/disable?

Thanks!

@Gowiem Gowiem added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels May 1, 2021
@Gowiem
Copy link
Member

Gowiem commented May 1, 2021

Good request. Hopefully somebody comes through and implements it! 👍

@Nuru
Copy link
Contributor

Nuru commented May 16, 2022

This has been implemented in terraform-aws-dynamic-subnets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants