This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EverlastingBugstopper
requested review from
steveklabnik,
ashleygwilliams,
ashleymichal and
gabbifish
November 19, 2019 21:27
steveklabnik
approved these changes
Nov 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this looks good overall! I have a few style pointers, some of which are purely personal preference, and i'm not familiar with all of wrangler, so maybe consistency is better. please pick and choose whichever of these you want to take advice from :)
thanks for the review @steveklabnik - super super helpful :) generally we do not have a style in wrangler and i would not describe it as consistent - very happy to follow these style suggestions |
EverlastingBugstopper
changed the title
Use async syntax for proxy
[proxy] Use async syntax for proxy
Nov 20, 2019
EverlastingBugstopper
changed the title
[proxy] Use async syntax for proxy
[dev] Use async syntax for proxy
Nov 20, 2019
EverlastingBugstopper
changed the title
[dev] Use async syntax for proxy
[dev] Use async syntax for dev server
Nov 20, 2019
[dev] Adds environment support to dev server
[dev] uses PR #28 of chrome-devtools-rs
[dev] fix windows builds and timeouts
move color handling to chrome-devtools-rs
EverlastingBugstopper
force-pushed
the
avery/a-time-sync
branch
from
February 6, 2020 18:58
c376a42
to
2b7a556
Compare
ashleymichal
approved these changes
Feb 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🆗
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #845
Wrangler Dev Server -- Feature Branch
Testing Instructions - these should be included in the rc when it gets cut
Testing
Your local
rustc -V
must be at least 1.39.0. You can update by runningrustup update stable
.You can install this branch by running
cargo install --git https://github.com/cloudflare/wrangler --branch avery/a-time-sync --debug --force
(eventually that will get merged and you can install from this branch)
Go to a worker directory and run
wrangler dev
and curl/postman away!