Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Use string for Additional Custom Link Attributes #42

Open
babs20 opened this issue Jul 7, 2023 · 0 comments
Open

Suggestion: Use string for Additional Custom Link Attributes #42

babs20 opened this issue Jul 7, 2023 · 0 comments

Comments

@babs20
Copy link
Contributor

babs20 commented Jul 7, 2023

I noticed the addition of types for custom link attributes which is great, but was thinking we shouldn't just use any as the value for additional properties. If the user does add additional properties these would have to be a string AFAIK from my testing of this feature with Storyblok's Content Delivery API. If you don't want to be too explicit, using an unknown would give better type safety.

I don't mind making a PR for this if it is something we want to go forward with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant