You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed the addition of types for custom link attributes which is great, but was thinking we shouldn't just use any as the value for additional properties. If the user does add additional properties these would have to be a string AFAIK from my testing of this feature with Storyblok's Content Delivery API. If you don't want to be too explicit, using an unknown would give better type safety.
I don't mind making a PR for this if it is something we want to go forward with.
The text was updated successfully, but these errors were encountered:
I noticed the addition of types for custom link attributes which is great, but was thinking we shouldn't just use
any
as the value for additional properties. If the user does add additional properties these would have to be astring
AFAIK from my testing of this feature with Storyblok's Content Delivery API. If you don't want to be too explicit, using anunknown
would give better type safety.I don't mind making a PR for this if it is something we want to go forward with.
The text was updated successfully, but these errors were encountered: