-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] NeoPixel enabling with SKR E3V3 shows error on compile #165
Comments
I ran into a few issues before seeing this error popup. with your configurations, I had to change a few things:
but I'm not sure what changed as to why this error came up.
in src/lcd/e3v2/proui/dwin.cpp
#if ALL(LED_CONTROL_MENU, HAS_COLOR_LEDS)
leds.set_color(
HMI_value.Led_Color.r,
HMI_value.Led_Color.g,
HMI_value.Led_Color.b
OPTARG(HAS_WHITE_LED, HMI_value.Led_Color.w)
);
leds.update();
#endif |
Awesome cheers mate, I'll give it a go this afternoon when I get home from work and update this comment. Thank you |
also, I edited the dwin.cpp part to include that snippet, but change it a bit here is the PR for it and if you want the branch I used to compile and test yourself here it is |
alright so i just copied your dwin.cpp and dwin.h from the PR branch into my current repo, change add NO_CONTROLLER_CUSTOM_WIRING_WARNING and im getting a heap of errors now lol
downloaded the new branch for the PR, pasted my config and config_a to it, commented out the wiring warning and it works 🙌 so i guess theres something in my files thats wonky thanks for the bud, greatly appreciate it |
in dwin_defines.h where - #if ALL(LED_CONTROL_MENU, HAS_COLOR_LEDS) && DISABLED(LED_COLOR_PRESETS)
+ #if ALL(LED_CONTROL_MENU, HAS_COLOR_LEDS) |
Did you test the latest release build?
Yes, and the problem still exists.
Bug Description
Hi,
trying to compile the latest build source for my X2,
ive added 5 Neo pixels and wanted to turn on the feature in Config and with doing so i keep running into this error on compile.
Marlin\src\lcd\e3v2\proui\dwin.cpp: In function 'void ApplyLEDColor()':
Marlin\src\lcd\e3v2\proui\dwin.cpp:2558:49: error: cannot convert 'LEDColor' to 'uint32_t' {aka 'long unsigned int'} in assignment
2558 | void ApplyLEDColor() { HMI_data.Led_Color = LEDColor({ leds.color.r, leds.color.g, leds.color.b OPTARG(HAS_WHITE_LED, leds.color.w) }); }
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| |
| LEDColor
Compiling .pio\build\STM32G0B1RE_btt\src\src\libs\vector_3.cpp.o
*** [.pio\build\STM32G0B1RE_btt\src\src\lcd\e3v2\proui\dwin.cpp.o] Error 1
any idea why this is happening or how to fix it?
Marlin.zip
removing LED Control Menu fixes this issue, but now i am unable to set startup led colour, and do not have a way to change colour besides submitting gcode, prior to printing
Printer Model
Voxelab Aquila
Model Type
X2
Your Mainboard
BTT SKR MINI E3 v3.0
Other Mainboard Type
No response
Add-ons that could be involved
No response
ProUI-EX | Extra Features?
Yes
Bed Leveling
UBL - Unified Bed Leveling
Did you include your own configuration files?
Configuration.h
andConfiguration_adv.h
.Additional information & file uploads
No response
The text was updated successfully, but these errors were encountered: