-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The PLY file generated is not an octree. #30
Comments
What‘s more, I've noticed that some anchors do not have a parent anchor. |
Thank you for your detailed suggestions. The problem you mentioned stems from the details of the anchor growth strategy, and we will modify it as soon as possible. |
The former is due to the anchor removing strategy, and the latter relates to the minimum and maximum length of the octree voxels. |
The existence of orphan anchors might be due to the growing strategy, which does not consider whether the candidates' parents exist. As to the latter, I don't understand why the minimum and maximum voxel sizes relate to it. Otherwise, I've also analyzed the number of duplicated anchors when I am re-training |
For duplicate anchors, we will update the code and weights file within the week. Besides, we have a general strategy for the orphan anchor problem, but it will take some time to adjust to get the best results. |
I've run the fixed code on |
Simply, when you add a new anchor, you (1) recursively complete all parent node (with the possibility of adding more than one anchor) or (2) recursively find the anchor and add the child anchor (with the guarantee of adding one anchor at a time). For example, when adding anchors in the same layer of the |
Thank you for your kind share. Looking forward to your updated release!! |
Congrats! I think such a slight decrease in visual performance is acceptable. Anyway, thank you for your effort in the community. Hopefully your brand new |
I've run the released code. During training, the anchors will be adjusted adaptively. However, the anchors in the generated PLY file can not be constructed as an octree because of ``children-node duplication''. I've read the logic of
anchor_growing
function defined in class `GaussianModel`. There're two stages of each `cur_level`. The first stage is to generate new anchors for level `cur_level`, and the second one generates anchors for level `cur_level + 1`, resulting in variables `candidate_anchor` and `candidate_anchor_ds` respectively. However, for `candidate_anchor_ds`, the `get_remove_duplication` should consider its duplication between `candidate_anchor_ds` with the anchors of `cur_level + 1` (as they eventually will be assigned a level value of `cur_level + 1`), while in the released code, is `cur_level`. I wonder the reason of setting the code like this.The text was updated successfully, but these errors were encountered: